Try to parse the year when 'year' tag could be a date #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhowden
requested changes
Apr 13, 2024
Co-authored-by: David Howden <dhowden@gmail.com>
dhowden
approved these changes
Apr 13, 2024
|
So I completely missed that the build was failing on here! |
|
...and I can't fix this it would seem. Can you bump the go.mod to 1.20 as that's the requirement for this? |
|
Done. |
|
I forgot the workflow file, now it should pass. |
dhowden
requested changes
Apr 15, 2024
dhowden
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the year/date tag is a date, it can't be parsed into a number, so the
Year()method returns a zero value. This PR tries to fix this by checking if theAtoi()function returns 0. If it does, the string is parsed as a date, and the year is returned. If parsing fails, it still returns zero.